Little Bugs in final version - Printable Version

The following warnings occurred:

Warning [2] Undefined variable $unreadreports - Line: 26 - File: global.php(961) : eval()'d code PHP 8.1.2-1ubuntu2.14 (Linux)

File	Line	Function
/global.php(961) : eval()'d code	26	errorHandler->error
/global.php	961	eval
/printthread.php	16	require_once

Little Bugs in final version - Printable Version

+- UserSpice (https://userspice.com/forums)
+-- Forum: Support Center (https://userspice.com/forums/forumdisplay.php?fid=23)
+--- Forum: UserSpice 4.3 and Below (https://userspice.com/forums/forumdisplay.php?fid=26)
+--- Thread: Little Bugs in final version (/showthread.php?tid=461)

Little Bugs in final version - Kighlander - 02-18-2017

Hey folks !

I just downloaded the final version of US4 and found some bugs:
When I use the facebook-login I got some fatal errors while loading the sources. I fixed two errors and after that the login with facebook works fine:

File: users/fb-callback.php
Line 16:
old:

Code:
require_once("/src/Facebook/autoload.php");

new:

Code:
require_once("src/Facebook/autoload.php");

File: users/includes/facebook_oauth.php
Line 51:
old:

Code:
require_once("/src/Facebook/autoload.php");

new:

Code:
require_once("src/Facebook/autoload.php");

-----
Also the FB-Button needs a fix to show on website:

File: users/includes/facebook_oauth.php
Line 64:
old:

Code:
.$us_url_root.'/users/images/facebook.png" alt=""/></a>';

new:

Code:
.$us_url_root.'users/images/facebook.png" alt=""/></a>';

-----

After that I also found an error with loading the jquery.js in file "header.php":

File: users/includes/header.php
Line 107:
old:

Code:
<script src="<?=$us_url_root?>users/js/jquery.min.js"></script>

new:

Code:
<script src="<?=$us_url_root?>users/js/jquery.js"></script>

-----

Now the installation works (until now) without any errors Wink

Yours

Kighlander

Little Bugs in final version - mudmin - 02-18-2017

Thank you! That feedback helps a lot. None of those things cause problems on my test system but your changes look right. I'll roll this out as the main code and then do a full update on Monday. Again, thank you!

Little Bugs in final version - mudmin - 02-18-2017

This patch to 4.2.0b is based on your feedback. You probably want to still install the patch because I fixed a few other bugs where the system was saying Welcome to UserSpice instead of Welcome to site_name (as defined in the database). Thank you again!

https://userspice.com/patch/420to420b.zip

Little Bugs in final version - Kighlander - 02-18-2017

No problem...
in the future I want this system use in production for my website.
Maybe there is a little thing you can also do in this build:
If activated I want the facebook login button (probably as bootstrap button) in the fixed navbar.
I tryed to do it on my own, but I failed...

I'm looking for further bugs and hacks Wink

Best regards

Kighlander

Little Bugs in final version - mudmin - 02-18-2017

Hmm. We should be able to make that happen. I'm not in front of my raw code, but you should be able to go into usersc/includes/navigation.php and add something like this...

Code:
if((!$user->isLoggedIn()) && $settings->fblogin == 1){

//if user is not logged in and facebook login is enabled

Code:
//make your fb login link here

Code:
}